Skip to content

chore: release 2.3.1#1049

Open
piotr-iohk wants to merge 8 commits into
masterfrom
ovi/release-2.3.0
Open

chore: release 2.3.1#1049
piotr-iohk wants to merge 8 commits into
masterfrom
ovi/release-2.3.0

Conversation

@piotr-iohk

@piotr-iohk piotr-iohk commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

Hotfix release 2.3.1 (build 183) on top of v2.3.0.

Description

  • Routes LNURL-pay invoice fetching through bitkit-core with full LnurlPayData validation
  • Maps core invoice validation errors to a neutral payment-canceled message
  • versionCode: 182 → 184
  • versionName: 2.3.0 → 2.3.1

Release

  • Tag: v2.3.1
  • Branch: ovi/release-2.3.0
  • Mainnet build/APK upload

Preview

N/A

QA Notes

  • Staging regtest: normal LN sends with QuickPay on/off
  • CI @lnurl_1 green with matching e2e branch (fix/lnurl-pay @ d00494d)
  • Unit tests: LightningRepoTest

Made with Cursor

ovitrif and others added 3 commits June 26, 2026 05:04
fix: use core LNURL-pay validation
Co-authored-by: Cursor <cursoragent@cursor.com>
@piotr-iohk piotr-iohk requested a review from ovitrif June 26, 2026 11:30
@greptile-apps

This comment was marked as off-topic.

Comment thread app/src/main/java/to/bitkit/ext/Coroutines.kt Outdated
Comment thread app/src/main/java/to/bitkit/repositories/LightningRepo.kt

@ovitrif ovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit that only warrants a change AFTER release artifacts are build, before merging back into master, which already defines a more complete implementation of runSuspendCatching.

Comment thread app/src/main/java/to/bitkit/ext/Coroutines.kt Outdated
Comment thread app/src/main/java/to/bitkit/repositories/LightningRepo.kt
Comment thread app/src/main/java/to/bitkit/ext/Coroutines.kt

@ovitrif ovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added another nit, again, no changes for 2.3.1, this is only merge hygiene to cover all conflicts reported.

Comment thread gradle/libs.versions.toml Outdated
@ovitrif ovitrif self-assigned this Jun 26, 2026
@piotr-iohk

Copy link
Copy Markdown
Collaborator Author

@ovitrif I'd leave conflict resolution and addressing nits to you to make this mergable, since you have better context on the fix. (same for corresponding ios PR)

@ovitrif

ovitrif commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

@ovitrif I'd leave conflict resolution and addressing nits to you to make this mergable, since you have better context on the fix. (same for corresponding ios PR)

Thank you sir, best reasoning for this 🙏

Wrapping it up for both repos 👀

@ovitrif ovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflicts are resolved, the review threads are addressed, and CI/E2E is green.

@ovitrif ovitrif requested a review from jvsena42 June 29, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants